On Tue, Jul 07, 2015 at 03:04:51PM +0300, Pavel Fedin wrote:
Hello!I don't think we should use enums at all in the protocol specification. It should be unsigned int and the change should be made separately. Is this hunk here because portable-rpcgen has problems with enum being declared there?Yes, its parser fails. I have checked throughout the code, there are some other enums in .x files too, but when they are put in structs, they are specified without 'enum' keyword and everything is fine. For example, virnetprotocol.x: --- cut --- struct virNetMessageHeader { unsigned prog; /* Unique ID for the program */ unsigned vers; /* Program version number */ int proc; /* Unique ID for the procedure within the program */ virNetMessageType type; /* Type of message */ unsigned serial; /* Serial number of message. */ virNetMessageStatus status; }; --- cut --- Here virNetMessageType and virNetMessageStatus are enums. Actually i borrowed fix method from here.
I see. I'm still a little bit hesitant about that, but that's pre-existing to your patch, so that shouldn't keep us away from that. Could you split that hunk into another patch and also fix it in lxc_monitor_protocol-structs so that make syntax-check doesn't bother us? Thanks, Martin
Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia
signature.asc
Description: PGP signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
