On 09/07/15 14:13, Ján Tomko wrote: > On Thu, Jul 09, 2015 at 01:48:16PM +0200, Erik Skultety wrote: >> This patch reverts commit 4749d82a which tried to tweak the logic in >> volume creation. We did realloc and update our object list before we executed >> volume building within a specific storage backend. If that failed, we >> had to update (again) our object list to the original state as it was before >> the >> build and delete the volume from the pool (even though it didn't exist - this >> truly depends on the backend). >> I misunderstood the base idea to be able to poll the status of the volume >> creation using vol-info. After commit 4749d82a this wasn't possible >> anymore, although no BZ has been reported yet. >> >> Commit 4749d82a also claimed to fix >> https://bugzilla.redhat.com/show_bug.cgi?id=1223177, but commit c8be606b of >> the >> same series as 4749d82ad (which was more of a refactor than a fix) >> fixes the same issue so the revert should be pretty straightforward. >> Further more, BZ https://bugzilla.redhat.com/show_bug.cgi?id=1241454 can be >> fixed with this revert. >> --- >> src/storage/storage_driver.c | 28 ++++++++++++++++++---------- >> 1 file changed, 18 insertions(+), 10 deletions(-) > > ACK > > Jan > Thanks, now pushed. Erik
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
