On Wed, Jan 20, 2016 at 04:11:26PM +0100, Michal Privoznik wrote: > We are getting the list of domains and after that we iterate over > the list and try to get status for each domain hoping it will > skip over domains that disappeared meanwhile. However, this > solution to race is bogus - domain may disappear right after we > have checked its state and before we exec another API over it > (e.g. virDomainHasManagedSaveImage()). Also, when printing just
There seems to be a similar problem in virshDomainListCollect, but it is only used with old libvirtd that does not support the atomic listing API. > names or uuids (list --name / --uuid) we issue APIs to obtain the > values, however these require no RPC call as all requested info > is in virDomain object that client already has. > Therefore move the status obtaining only to the place that really > needs it. > > Signed-off-by: Michal Privoznik <[email protected]> > --- > tools/virsh-domain-monitor.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > ACK Jan
signature.asc
Description: Digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
