On Tue, Feb 16, 2016 at 19:44:16 -0500, John Ferlan wrote: > Reorganize the module to put the function after the -cpu processing > to form a logical order of processing for qemuBuildCommandLine working > top down in the module.
I'm not really a fan of this ... > > Signed-off-by: John Ferlan <[email protected]> > --- > src/qemu/qemu_command.c | 141 > ++++++++++++++++++++++++------------------------ > 1 file changed, 71 insertions(+), 70 deletions(-) > > diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c > index 9dbc4a3..70da921 100644 > --- a/src/qemu/qemu_command.c > +++ b/src/qemu/qemu_command.c > @@ -790,6 +790,77 @@ qemuBuildCpuCommandLine(virCommandPtr cmd, > } It doesn't remove a forward declaration of a static function, just shuffles code around. > +/** Start Domain Loader (-bios, file=%s,if=pflash) arguments */ This is yet another new style to the src/qemu subtree. > +static int > +qemuBuildDomainLoaderCommandLine(virCommandPtr cmd, I don't think it's worth moving the code so that it just is in the correct order. Is there any other reason? Peter
signature.asc
Description: Digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
