Hello Peter, Thanks for the reply. I have made changes according to your suggestion and re-submitted the patch as [patch v2] on the mailing list. Link:- https://www.redhat.com/archives/libvir-list/2016-February/msg01071.html
Warm Regards, Nitesh Konkar. On Fri, Feb 19, 2016 at 8:57 PM, Peter Krempa <[email protected]> wrote: > On Fri, Feb 19, 2016 at 07:24:17 -0500, Nitesh Konkar wrote: > > > > This patch gives an error when migration is attempted with both > > --live and --offline options. > > > > Signed-off-by: Nitesh Konkar <[email protected]> > > --- > > tools/virsh-domain.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c > > index 62acecb..527db38 100644 > > --- a/tools/virsh-domain.c > > +++ b/tools/virsh-domain.c > > @@ -9795,6 +9795,12 @@ doMigrate(void *opaque) > > } else { > > /* For traditional live migration, connect to the destination > host directly. */ > > virDomainPtr ddom = NULL; > > + > > + if ((flags & VIR_MIGRATE_OFFLINE) && (flags & > VIR_MIGRATE_LIVE)){ > > + vshError(ctl, "%s", _("migrate: Using both --live and > --offline option together is not permitted.")); > > + goto out; > > + } > > > This should be validated in the callers using one of the > VSH_EXCLUSIVE_OPTIONS_* macros. > > Peter >
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
