Hi jiri,
Thanks for you kindly reviewing, I wonder what cpu/cpu_map.xml does in libvirt
if QEMU already provide all features to guest?
Best Regards,
Qiao, Liyong (Eli) OTC SSG Intel
------------------------------------------------
此致
敬礼！
英特尔（中国）有限公司软件与服务部开源技术中心 乔立勇
-----Original Message-----
From: Jiri Denemark [mailto:[email protected]]
Sent: Friday, May 06, 2016 6:56 PM
To: Qiao, Liyong <[email protected]>
Cc: [email protected]
Subject: Re: [libvirt] [PATCH] cpu: add ABM to Haswell* and
Broadwell* CPU models
On Fri, May 06, 2016 at 17:53:04 +0800, Eli Qiao wrote:
> Corresponding QEMU commits:
> becb66673ec30cb604926d247ab9449a60ad8b11
>
> Signed-off-by: Eli Qiao <[email protected]>
> ---
> src/cpu/cpu_map.xml | 4 ++++
> 1 file changed, 4 insertions(+)
NACK. We don't add features to models since it could break
existing setups. In any case, presence of any flag in CPU models
does not really influence whether that flag is going to be
provided
to a guest. That part is driven by QEMU.
Jirka
--
libvir-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libvir-list
