Pavel Hrdina wrote: > Clang complains about wrong argument type: > > libvirt/src/security/virt-aa-helper.c:174:11: error: absolute value > function 'abs' given an argument of type 'long' but has parameter > of type 'int' which may cause truncation of value > [-Werror,-Wabsolute-value] > idx = abs(pos - orig);
Out of curiosity, why not use labs() here instead of casting? > Signed-off-by: Pavel Hrdina <[email protected]> > --- > src/security/virt-aa-helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c > index 7eeb4ef..14f8afb 100644 > --- a/src/security/virt-aa-helper.c > +++ b/src/security/virt-aa-helper.c > @@ -171,7 +171,7 @@ replace_string(char *orig, const size_t len, const char > *oldstr, > } > tmp[0] = '\0'; > > - idx = abs(pos - orig); > + idx = abs((int)(pos - orig)); > > /* copy everything up to oldstr */ > strncat(tmp, orig, idx); > -- > 2.8.2 > > -- > libvir-list mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/libvir-list Roman Bogorodskiy -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
