Hi On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina <phrd...@redhat.com> wrote: > So far we have only two listen types that supports only address:port > method, but in the future we may want to add a new different listen > type, for example socket. > > This patch moves the ports values out of graphics unions into listen > element. The domain XML will now duplicate the ports from first listen > element into the graphics element as we do also for address. > > This allows us to make part of the graphics code as listen-driven and > prepare the code for new listen types. > > To support migration back to older versions the new attributes from > listen elements are not written into migratable XML. > > Signed-off-by: Pavel Hrdina <phrd...@redhat.com>
This patch is pretty large, so I have been only skimming through, most changes are straightforward. Overall, it looks good to me. Someone more familiar with libvirt & network code, and migration support, should do a more thorough review. Tested-by: Marc-André Lureau <marcandre.lur...@redhat.com> -- Marc-André Lureau -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
