On Thu, Jun 09, 2016 at 05:43:05PM -0400, Cole Robinson wrote:
> On 06/09/2016 02:25 PM, Jovanka Gulicoska wrote:
> > + virReportInvalidArg(eventID,
> > + _("eventID in %s must be less than %d"),
> > + __FUNCTION__, VIR_STORAGE_POOL_EVENT_ID_LAST);
> > + goto error;
> > + }
> > +
> > + if (conn->storageDriver &&
> > conn->storageDriver->connectStoragePoolEventRegisterAny) {
>
> Long line, split it after the &&
>
> > + int ret;
> > + ret =
> > conn->storageDriver->connectStoragePoolEventRegisterAny(conn, pool,
> > +
> > eventID,
> > + cb,
> > opaque,
> > +
> > freecb);
>
> If you put pool and opaque on their own lines this breaks some over 80 column
> lines, but I don't know if that's better or worse
>
The 'Any' suffix can also be dropped.
There is no legacy virConnectStoragePoolEventRegister API so we don't
need to add suffixes like we had to for virConnectDomainEventRegister.
Jan
--
libvir-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libvir-list
