On Mon, Aug 8, 2016 at 2:15 PM, Michal Privoznik <[email protected]> wrote:
> On 08.08.2016 03:53, [email protected] wrote: > > From: Kai Kang <[email protected]> > > > > When build for architecture that don't use gcc atomic ops but pthread, > > it fails to build for armel: > > > > | ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): > In function `virClassNew': > > | /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/ > tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/ > build/src/../../libvirt-1.3.5/src/util/virobject.c:153: undefined > reference to `virAtomicLock' > > | ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): > In function `virObjectNew': > > | /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/ > tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/ > build/src/../../libvirt-1.3.5/src/util/virobject.c:205: undefined > reference to `virAtomicLock' > > | ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): > In function `virObjectUnref': > > | /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/ > tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/ > build/src/../../libvirt-1.3.5/src/util/virobject.c:277: undefined > reference to `virAtomicLock' > > | ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): > In function `virObjectRef': > > | /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/ > tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/ > build/src/../../libvirt-1.3.5/src/util/virobject.c:298: undefined > reference to `virAtomicLock' > > | collect2: error: ld returned 1 exit status > > > > It is similar with: > > > > http://libvirt.org/git/?p=libvirt.git;a=commit;h=12dc729 > > > > Signed-off-by: Kai Kang <[email protected]> > > --- > > src/Makefile.am | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/src/Makefile.am b/src/Makefile.am > > index 12b66c2..6e55972 100644 > > --- a/src/Makefile.am > > +++ b/src/Makefile.am > > @@ -2989,6 +2989,8 @@ noinst_LTLIBRARIES += libvirt-nss.la > > libvirt_nss_la_SOURCES = \ > > util/viralloc.c \ > > util/viralloc.h \ > > + util/viratomic.c \ > > + util/viratomic.h \ > > util/virbitmap.c \ > > util/virbitmap.h \ > > util/virbuffer.c \ > > > > ACKed and pushed. Congratulations on your first libvirt contribution. > > Thanks. :) --Kai > And it's nice to see people using feature I wrote. I often think how > many users does this plugin has. I know, I know - compiling is not > using, but still :) > > Michal >
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
