On Thu, Sep 15, 2016 at 18:14:31 +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mklet...@redhat.com>
> ---
>  src/libvirt_private.syms                       | 2 ++
>  src/qemu/qemu_command.c                        | 4 ++++
>  tests/qemuxml2argvdata/qemuxml2argv-shmem.args | 4 ++--
>  3 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index 409e0c0018e6..31020e6dc207 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -456,6 +456,8 @@ virDomainSeclabelTypeFromString;
>  virDomainSeclabelTypeToString;
>  virDomainShmemModelTypeFromString;
>  virDomainShmemModelTypeToString;
> +virDomainShmemRoleTypeFromString;
> +virDomainShmemRoleTypeToString;
>  virDomainShutdownReasonTypeFromString;
>  virDomainShutdownReasonTypeToString;
>  virDomainShutoffReasonTypeFromString;

This hunk probably belongs to previous patch.

> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 5eae0631a14f..60d662270cc8 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -8583,6 +8583,10 @@ qemuBuildShmemDevStr(virDomainDefPtr def,
> 
>      if (!shmem->server.enabled) {
>          virBufferAsprintf(&buf, ",shm=%s,id=%s", shmem->name, 
> shmem->info.alias);
> +        if (shmem->role) {
> +            virBufferAsprintf(&buf, ",role=%s",
> +                              virDomainShmemRoleTypeToString(shmem->role));
> +        }

Yup, previous patch needs more explanation.

>      } else {
>          virBufferAsprintf(&buf, ",chardev=char%s,id=%s", shmem->info.alias, 
> shmem->info.alias);
>          if (shmem->msi.enabled) {

ACK

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to