On Fri, Sep 16, 2016 at 09:22:39 +0200, Peter Krempa wrote:
> On Thu, Sep 15, 2016 at 18:14:31 +0200, Martin Kletzander wrote:
> > Signed-off-by: Martin Kletzander <mklet...@redhat.com>
> > ---
> >  src/libvirt_private.syms                       | 2 ++
> >  src/qemu/qemu_command.c                        | 4 ++++
> >  tests/qemuxml2argvdata/qemuxml2argv-shmem.args | 4 ++--
> >  3 files changed, 8 insertions(+), 2 deletions(-)

[...]

> > diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> > index 5eae0631a14f..60d662270cc8 100644
> > --- a/src/qemu/qemu_command.c
> > +++ b/src/qemu/qemu_command.c
> > @@ -8583,6 +8583,10 @@ qemuBuildShmemDevStr(virDomainDefPtr def,
> > 
> >      if (!shmem->server.enabled) {
> >          virBufferAsprintf(&buf, ",shm=%s,id=%s", shmem->name, 
> > shmem->info.alias);
> > +        if (shmem->role) {
> > +            virBufferAsprintf(&buf, ",role=%s",
> > +                              virDomainShmemRoleTypeToString(shmem->role));
> > +        }
> 
> Yup, previous patch needs more explanation.
> 
> >      } else {
> >          virBufferAsprintf(&buf, ",chardev=char%s,id=%s", 
> > shmem->info.alias, shmem->info.alias);
> >          if (shmem->msi.enabled) {
> 
> ACK

I take back. I've read the commit you've pointed out a few patches
later:

* Property "role" replaced by "master".  role=master becomes
  master=on, role=peer becomes master=off.  Default is off instead of
  auto.

I don't think it makes any sense to expose the old stuff since it does
not work anyways and we never used it apparently.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to