On 09/16/2016 08:30 AM, Daniel P. Berrange wrote:
> On Fri, Sep 16, 2016 at 03:06:27PM +0200, Tomáš Ryšavý wrote:
>> Because the file had over 7000 lines. Now its splitted into 5
>> smaller files. It looks clearer and it's better for reading the code.
>>
>> Signed-off-by: Tomáš Ryšavý <tom.rysav...@gmail.com>
>> ---

> 
> Doing this is all in one patch is *way* too much change at
> once.
> 
> Please split this into at least 4 patches, one for each new new .c
> file you create.

Agreed.  Here's another hint: code motion patches can be made VERY easy
to review, but only if your commit is limited to moving contents from
one file to another in the same ordering (any time you scattershot
functions from one file into multiple others, or reorder things on move,
this trick doesn't work):

http://wiki.qemu.org/Contribute/SubmitAPatch#Make_code_motion_patches_easy_to_review

(Not all of the qemu patch submission rules apply to libvirt, but this
hint about code motion reviews can be applied to any project)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to