On 16/09/16 13:58, Ján Tomko wrote:
> On Fri, Sep 16, 2016 at 12:50:41PM +0200, Erik Skultety wrote:
>> Originally introduced by commit 2432521e which correctly split
>> vshCmddefOptParse into command's options validation and options parsing.
>> However, command's 'internals' are not tied solely to .options, rather it
>> should be about the overall structure, therefore the validation should be
>> extracted from vshCmddefOptParse and performed before any attempt to
>> parse the
>> command's options.
>> Signed-off-by: Erik Skultety <eskul...@redhat.com>
>> ---
>> tools/vsh.c | 18 +++++++++++++-----
>> 1 file changed, 13 insertions(+), 5 deletions(-)
> While this change makes sense on its own, this function is only used for
> a run-time check of our data. Maybe the only place to call it should be
> the self test command?
> Jan

I think we could do this, since not paying attention to the results of
our test suite would be developer's ignorance, so I'll update the patch.


libvir-list mailing list

Reply via email to