On 08/18/2016 07:47 AM, Erik Skultety wrote:
> Introduce a method to parse an individual logging output. The difference
> compared to the virLogParseAndDefineOutput is that this method does not define
> the output, instead it makes use of the virLogNewOutputTo* methods introduced
> in the previous patch and just returns the virLogOutput object that has to be
> added to a list of object which then can be defined as a whole via
> virLogDefineOutputs. The idea remains still the same - split parsing and
> defining of the logging primitives (outputs, filters).
> Signed-off-by: Erik Skultety <eskul...@redhat.com>
> ---
>  src/libvirt_private.syms |  1 +
>  src/util/virlog.c        | 71 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  src/util/virlog.h        |  1 +
>  3 files changed, 73 insertions(+)

Since I've now reached patch 18...

If you use the ATTRIBUTE_UNUSED from patch 7, then this is where you'd
remove that since the virLogNewOutputTo* functions are now called.

Even if you didn't, there's no reason to have the .h file and the
entrypoints in private.syms after this point...  So 18 would move to
after this patch.  I'd prefer to see the ATTRIBUTE_UNUSED.


libvir-list mailing list

Reply via email to