On 08/18/2016 07:47 AM, Erik Skultety wrote:
> Now that previous patches tried to refactor the code and split parsing and
> defining logic of logging primitives, there is no reason why we could not keep
> journald's fd within the journald output object the same way as we do for
> regular file-based outputs. Quite the opposite, by doing that we gain the
> benefit of creating a journald-based object the same way as we create
> file-based ones and therefore when replacing the existing set of outputs
> for a new one, journald does not need to be special cased due to its globally
> shared fd and the only remaining thing to special case is syslog. 
> Additionally,
> making this change, we don't need the virLogCloseJournald routinei anymore,
> since as it stores the fd within the object, plain virLogCloseFd will suffice.
> Signed-off-by: Erik Skultety <eskul...@redhat.com>
> ---
>  src/util/virlog.c | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)

I am OK with things going in this order, although part of me is curious
why it couldn't happen sooner.

ACK in principal though


libvir-list mailing list

Reply via email to