On 10/10/2016 12:32 PM, Stefan Bader wrote: > On 10.10.2016 17:06, Cole Robinson wrote: >> On 10/07/2016 03:56 AM, Stefan Bader wrote: >>> Two small changes, before I forget about submitting them... >>> >>> First one affects all environments the same. The list of UIDs which >>> is generated has each element on a separate line. And using quotes >>> in the echo preserves those newlines. However the processing assumes >>> one line per URI and all UIDs separated by spaces. So without dropping >>> the quotes only one guest will get shutdown/suspended. >>> >>> The second change is for Xen environments only. Domain-0 appears in >>> the list of guests and it is a persistent one. So on shutdown, the >>> script tries to stop Domain-0 (which is not working) and then waits >>> the whole timeout for it to stop. >>> >> >> Note these patches were flagged as problematic a few months back: >> https://bugzilla.redhat.com/show_bug.cgi?id=1335585 >> >> Stefan, have you heard about that issue? Was it resolved with these versions? > > I did not hear about that before. But revisiting things again I think what > happened is that the Xen patch which I had done before (but at that time > forgot > to submit upstream) was adding quotes there because without, the grep does not > work. Back then I did not realize this broke the shutdown as that also had > quotes around the list. All the other users of the list are ok because they > wrap > the processing into for ... loops and for those newline or space does not > matter. > > So together with the other patch wich drops the quotes when writing the list > file this should be resolved. list_guests returns a list of uids (separated by > newline), the output of the info message is correctly showing names in one > line > separated by komma, and the produced list file had only one line per uri with > uids separated by spaces.
Sounds good, I'll close that bug then Thanks, Cole -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
