On Wed, Oct 12, 2016 at 02:12:55PM +0200, Pavel Hrdina wrote:
This improves commit 706b5b6277 in a way that we check qemu capabilities
instead of what architecture we are running on to detect whether we can
use *virtio-vga* model or not.  This is not a case only for arm/aarch64.

Signed-off-by: Pavel Hrdina <phrd...@redhat.com>
---

ACKed

Changes in v2:
   - improved commit message

src/qemu/qemu_command.c                            |  4 +--
src/qemu/qemu_domain.c                             | 12 ++++++++
src/qemu/qemu_domain.h                             |  3 ++
.../qemuxml2argv-video-virtio-gpu-device.args      |  2 +-
.../qemuxml2argv-video-virtio-gpu-spice-gl.args    |  2 +-
.../qemuxml2argv-video-virtio-gpu-virgl.args       |  2 +-
.../qemuxml2argv-video-virtio-vga.args             | 24 ++++++++++++++++
.../qemuxml2argv-video-virtio-vga.xml              | 33 ++++++++++++++++++++++
tests/qemuxml2argvtest.c                           |  4 +++
9 files changed, 80 insertions(+), 6 deletions(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-vga.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-vga.xml


diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index c937858..cd574fb 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -6244,3 +6244,15 @@ qemuDomainCheckMonitor(virQEMUDriverPtr driver,

    return ret;
}
+
+
+bool
+qemuDomainSupportVideoVga(virDomainVideoDefPtr video,

Maybe 'Supports'?

ACK regardless.

Jan


+                          virQEMUCapsPtr qemuCaps)
+{
+    if (video->type == VIR_DOMAIN_VIDEO_TYPE_VIRTIO &&
+        !virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_VGA))
+        return false;
+
+    return true;
+}

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to