On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> We tend to prevent using 'default' in switches. And it is for a
> good reason - control may end up in paths we wouldn't want for
> new values. In this specific case, if qemuBuildHostNetStr is
> called over VIR_DOMAIN_NET_TYPE_VHOSTUSER it would produce
> meaningless output. Fortunately, there no such call yet.
> Signed-off-by: Michal Privoznik <mpriv...@redhat.com>
> ---
>  src/qemu/qemu_command.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)

Doesn't seem anything changed from the original patch (which is fine).

Yet another function that doesn't use/need the 'cfg' variable...

ACK to what's here, I'd support removing cfg as well


libvir-list mailing list

Reply via email to