On Wed, Jan 25, 2017 at 03:27:38PM -0500, John Ferlan wrote: > Rework the code to perform the various searches by parent, parent_wwnn/ > parent_wwpn, parent_fabric_wwn, or vport capable in order to return the > 'parent_host' number that is vHBA capable. > > The former virNodeDeviceGetParentHost is renamed to add the ByParent > on it fixes an issue where if no parent was supplied in the XML to > create the vHBA, then virNodeDeviceFindByName was called with a NULL > second parameter which had bad results. > > The reworked code will make the various calls to fetch the NPIV host > by the passed parameter options or if none are provided find a vport > capable NPIV HBA to perform the create. If the call is from the delete > path, then this option won't be allowed. > > Each of virNodeDeviceGetParentHostBy* functions is now static, so > remove them external definitions. > > Alter the calling logic to match the
You've probably forgot to remove or finish the sentence. > A secondary benefit of this is the test_driver now can make use of > the new API to add some new tests to test the various creation options. > > Signed-off-by: John Ferlan <jfer...@redhat.com> > --- > src/conf/node_device_conf.c | 68 > +++++++++++++++++++++++------------- > src/conf/node_device_conf.h | 19 ++-------- > src/libvirt_private.syms | 3 -- > src/node_device/node_device_driver.c | 55 ++++++++--------------------- > src/test/test_driver.c | 24 ++++++------- > 5 files changed, 71 insertions(+), 98 deletions(-) ACK Pavel
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
