On Wed, Jul 08, 2009 at 04:09:10PM +0200, Jim Meyering wrote: > Daniel Veillard wrote: > > > On Wed, Jul 08, 2009 at 11:53:58AM +0200, Jim Meyering wrote: > >> + nodedevschemadata \ > >> + $(patsubst %,qemuhelpdata/%,$(qemuhelpdata)) > > > > Sounds good, but hum, that is cryptic ! > > Pushed. > It's a GNU make idiom to factor out the repeated qemuhelpdata/ prefix. > > The following is equivalent. > If you'd like, I can commit this patch, too. > > diff --git a/tests/Makefile.am b/tests/Makefile.am > index f8bde34..4f2520b 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -36,13 +36,6 @@ LDADDS = \ > $(LIBSOCKET) \ > $(COVERAGE_LDFLAGS) > > -qemuhelpdata = \ > - kvm-74 \ > - kvm-86 \ > - qemu-0.10.5 \ > - qemu-0.9.1 \ > - qemu-kvm-0.10.5 > - > EXTRA_DIST = \ > oomtrace.pl \ > test-lib.sh \ > @@ -59,7 +52,11 @@ EXTRA_DIST = \ > storagevolschemadata \ > nodedevschematest \ > nodedevschemadata \ > - $(patsubst %,qemuhelpdata/%,$(qemuhelpdata)) > + qemuhelpdata/kvm-74 \ > + qemuhelpdata/kvm-86 \ > + qemuhelpdata/qemu-0.10.5 \ > + qemuhelpdata/qemu-0.9.1 \ > + qemuhelpdata/qemu-kvm-0.10.5
okay, that's clearer but less useful :-) so keep it that way thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ [email protected] | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
