On Wed, Aug 09, 2017 at 01:14:59PM +0100, Daniel P. Berrange wrote:
On Wed, Aug 09, 2017 at 02:00:06PM +0200, Michal Privoznik wrote:Currently, there's a bug when undefining a domain with NVRAM store. Basically, the unlink() of the NVRAM store file happens during the undefine procedure iff domain is inactive. So, if domain is running and undefine is called the file is left behind. It won't be removed in the domain cleanup process either (qemuProcessStop). To avoid this forbid undefining domain with NVRAM file.Why do we need to forbid it ? Even if QEMU still has an open file handle, it can continue to write to it after we unlink it.
It was a suggestion, because that's what will people expect, IMHO. Feel free to go with the first version if that's what Dan prefers.
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list email@example.com https://www.redhat.com/mailman/listinfo/libvir-list
Description: Digital signature
-- libvir-list mailing list firstname.lastname@example.org https://www.redhat.com/mailman/listinfo/libvir-list