On Fri, Nov 03, 2017 at 03:29:23PM +0100, Peter Krempa wrote:
From: John Ferlan <[email protected]>--- +static virJSONValuePtr +qemuBlockStorageSourceGetISCSIProps(virStorageSourcePtr src) +{
[...]
+ if (VIR_STRDUP(target, src->path) < 0)
+ goto cleanup;
+
+ /* Separate the target and lun */
+ if ((lunStr = strchr(target, '/'))) {
+ *(lunStr++) = '\0';
+ if (virStrToLong_ui(lunStr, NULL, 10, &lun) < 0) {
+ virReportError(VIR_ERR_INTERNAL_ERROR,
+ _("cannot parse target for lunStr '%s'"),
+ target);
+ goto cleanup;
+ }
+ }
+
+ /* combine host and port into portal */
+ if (virAsprintf(&portal, "%s:%u", src->hosts[0].name, src->hosts[0].port)
< 0)
+ goto cleanup;
Can src->hosts[0].name possibly be a literal IPv6 address? Jan
signature.asc
Description: Digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
