On Mon, Nov 06, 2017 at 14:11:30 +0100, Andrea Bolognani wrote:
> Introduced in d86fd2402e9d. Fails to compile on aarch64 with
>
> qemu/qemu_driver.c: In function 'qemuDomainSetInterfaceParameters':
> ./conf/domain_conf.h:3406:1: error: inlining failed in call to
> 'virDomainNetTypeSharesHostView': call is unlikely and code size
> would grow [-Werror=inline]
> virDomainNetTypeSharesHostView(const virDomainNetDef *net)
> ^
> qemu/qemu_driver.c:11240:66: error: called from here [-Werror=inline]
> !virDomainNetTypeSharesHostView(net)) < 0 ||
> ^
>
> Solve the issue by turning it into a regular function.
Already pushed as
commit bce925dadaf8fe4693abee88fb68aa7ede9d209e
Refs: [master], {origin/master}, {origin/HEAD}, v3.9.0-39-gbce925dad
Author: Jiri Denemark <[email protected]>
AuthorDate: Thu Nov 2 19:58:00 2017 +0100
Commit: Jiri Denemark <[email protected]>
CommitDate: Mon Nov 6 10:58:46 2017 +0100
conf: Don't inline virDomainNetTypeSharesHostView
When coverage build is enabled, gcc complains about it:
In file included from qemu/qemu_agent.h:29:0,
from qemu/qemu_driver.c:47:
qemu/qemu_driver.c: In function 'qemuDomainSetInterfaceParameters':
./conf/domain_conf.h:3397:1: error: inlining failed in call to
'virDomainNetTypeSharesHostView': call is unlikely and code size would
grow [-Werror=inline]
virDomainNetTypeSharesHostView(const virDomainNetDef *net)
^
Signed-off-by: Jiri Denemark <[email protected]>
Jirka
--
libvir-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libvir-list
