At 2018-01-12 17:44:38, "Jiri Denemark" <jdene...@redhat.com> wrote: >On Fri, Jan 12, 2018 at 17:09:10 +0800, Chen Hanxiao wrote: >> From: Chen Hanxiao <chenhanx...@gmail.com> >> >> As the description of daemon/libvirtd.conf, setting >> key_file, cert_file or key_file will override the default value. >> But if we set any one of them, we need to set all the rest of them. > >I think this is a reasonable behavior. If a default value is not usable >for one of them, the other will likely need to be changed too. > >Although ca_file could be separated. In other words, I can imagine >someone wants to change ca_file but keep default values for >cert_file/key_file or keep default ca_file and override >cert_file/key_file. Overriding cert_file or key_file only without also >changing the other one doesn't make a lot of sense. > >Anyway, the patch is incorrect... >
Thanks for the review. I'll post another patch for the description of the conf. Regards, - Chen -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
