On 02/09/2018 04:15 AM, Daniel P. Berrangé wrote:
On Thu, Feb 08, 2018 at 01:24:58PM -0600, Chris Friesen wrote:


Given your comment above about "I don't want to see the semantics of that
change", it sounds like you're suggesting:

1) If there are any non-shared non-readonly network drives then the user
can't rely on the default behaviour of VIR_MIGRATE_NON_SHARED_INC to do the
right thing and therefore must explicitly specify the list of drives to
migrate

I would not make that conditional. Just always specific the list of disk
to migrate, if you're using new enough libvirt.

2) If there are no drives to migrate, then it is not valid to specify
VIR_MIGRATE_NON_SHARED_INC with an empty "migrate_disks", but instead the
caller should ensure that VIR_MIGRATE_NON_SHARED_INC is not set.

Yes, don't ask for shared storage migration if there's no storage to
migrate.

Thanks for the clarifications.

Chris

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to