It's surprising that nobody ever noticed in the past that this test
was either failing, or wasn't testing what it intended to test.

An extra bonus to fixing the test is that we are now testing
virNWFilterDefineXML(), and while writing it I discovered that
define_nwfilter() has been missing from the perl bindings since the
very beginning (libvirt-0.8.0, nearly 7 years ago!). (Since nobody
complained before now, I guess anyone using nwfilter via perl was only
using pre-define filter rules).

Laine Stump (2):
  cleanup all nwfilters beginning with ^tck
  Fix no-mac-broadcast test

 lib/Sys/Virt/                     | 16 ++++++++++++++++
 scripts/nwfilter/230-no-mac-broadcast.t | 29 ++++++++++++++++++++++++++++-
 2 files changed, 44 insertions(+), 1 deletion(-)


libvir-list mailing list

Reply via email to