On 03/06/2018 12:31 PM, Michal Privoznik wrote:
> On 03/02/2018 02:58 AM, John Ferlan wrote:
>>
>>
>> On 02/21/2018 01:11 PM, Michal Privoznik wrote:
>>> The capability tracks if qemu has pr-manager-helper object. At
>>> this time don't actually detect if qemu has the capability. Not
>>> just yet. Only after the code is written the feature will be
>>> enabled.
>>>
>>> Signed-off-by: Michal Privoznik <mpriv...@redhat.com>
>>> ---
>>>  src/qemu/qemu_capabilities.c | 1 +
>>>  src/qemu/qemu_capabilities.h | 1 +
>>>  2 files changed, 2 insertions(+)
>>>
>>
>> Very strange to not see the replies or xml files adjusted here.
>>
>> And why is patch 12 not merged in here?  Like it was in v1 where you got
>> an ACK from Peter?
> 
> Because Peter also said that the patches should be ordered in such way
> that after each patch nothing is broken. So I had two options:
> 
> a) rewrite all the patches from scratch, or
> b) separate the capability detection into its own patch so effectively
> there is no way to use the feature until the very last patch and thus
> there's nothing to break. This was used fairly often historically when
> we were introducing new features in multiple patches.
> 

Fair enough.  I assume that if we had 2.12 capabilities, the flag would
show up in one of the xml replies file...  I understand the point, just
strange to see it split. I'm fine with the split though.

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to