When support for mode=custom will be added in the future, semantics of
current config will change. Reduce the surprise by emitting a warning.
Signed-off-by: Marek Marczykowski-Górecki <marma...@invisiblethingslab.com>
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
---
Changes since v5:
- new patch, instead of "libxl: error out on not supported CPU mode,
instead of silently ignoring"
---
src/libxl/libxl_conf.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index 2565f64..2053ed3 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -424,6 +424,12 @@ libxlMakeDomBuildInfo(virDomainDefPtr def,
libxl_defbool_set(&b_info->u.hvm.nested_hvm, hasHwVirt);
}
+ if (def->cpu && def->cpu->mode == VIR_CPU_MODE_CUSTOM) {
+ VIR_WARN("Ignoring CPU with mode=custom, update your config to "
+ "mode=host-passthrough to avoid risk of changed guest "
+ "semantics when mode=custom is supported in the future");
+ }
+
if (def->nsounds > 0) {
/*
* Use first sound device. man xl.cfg(5) describes soundhw as
--
git-series 0.9.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
