On Wed, Apr 11, 2018 at 04:41:06PM +0200, Jiri Denemark wrote:
Restore the original values of all migration parameters we store in
qemuDomainJobObj instead of explicitly resting only a limited set of

The result is not strictly equivalent to the previous code wrt reseting
TLS state because the previous code would only reset it if we changed it
before while the new code will reset it always if QEMU supports TLS
migration. This is not a problem for the parameters themselves, but it
can cause spurious errors about missing TLS objects being logged at the
end of non-TLS migration. This issue will be fixed ~50 patches later.

It better be.

Signed-off-by: Jiri Denemark <jdene...@redhat.com>
src/qemu/qemu_migration.c        | 20 +++++++++----
src/qemu/qemu_migration_params.c | 48 +++++++++++---------------------
src/qemu/qemu_migration_params.h |  3 +-
src/qemu/qemu_process.c          |  4 +--
4 files changed, 34 insertions(+), 41 deletions(-)

Reviewed-by: Ján Tomko <jto...@redhat.com>


Attachment: signature.asc
Description: Digital signature

libvir-list mailing list

Reply via email to