On Fri, Apr 13, 2018 at 02:17:45PM +0200, Andrea Bolognani wrote:
> On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote:
> > diff --git a/guests/vars/projects/libvirt-glib.yml 
> > b/guests/vars/projects/libvirt-glib.yml
> > index 13a5128..bb21ae0 100644
> > --- a/guests/vars/projects/libvirt-glib.yml
> > +++ b/guests/vars/projects/libvirt-glib.yml
> > @@ -5,4 +5,6 @@ packages:
> >    - gtk-doc
> >    - intltool
> >    - libxml2
> > +  - mingw32-glib2
> > +  - mingw64-glib2
> >    - vala
> 
> You're missing a lot of packages here, probably because they are
> already used for the libvirt MinGW build and you didn't reset your
> test machine between builds, thus masking the issue.

No I didn't miss them, I only listed stuff that's unique to
libvirt-glib - duplicating everything used by libvirt mingw
builds, under libvirt-glib mingw builds is not required, as
they're already present, and most are not even used by
libvirt-glib

> 
> The list of additional packages should look like:
> 
>   - mingw32-curl
>   - mingw32-dbus
>   - mingw32-dlfcn
>   - mingw32-gcc
>   - mingw32-gettext
>   - mingw32-glib2
>   - mingw32-gnutls
>   - mingw32-libssh2
>   - mingw32-libxml2
>   - mingw32-pkg-config
>   - mingw32-portablexdr
>   - mingw64-curl
>   - mingw64-dbus
>   - mingw64-dlfcn
>   - mingw64-gcc
>   - mingw64-gettext
>   - mingw64-glib2
>   - mingw64-gnutls
>   - mingw64-libssh2
>   - mingw64-libxml2
>   - mingw64-pkg-config
>   - mingw64-portablexdr



> 
> With that fixed,
> 
>   Reviewed-by: Andrea Bolognani <abolo...@redhat.com>
> 
> -- 
> Andrea Bolognani / Red Hat / Virtualization

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to