These changes affect only "make syntax-check". The first patch is clearing out now-useless or unnecessary exclusions. The second enables one more test and fixes the few small violations it spotted.
>From e4719bd092b03ef666d196ebc4b97086a7ecae98 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[email protected]> Date: Tue, 8 Sep 2009 15:08:07 +0200 Subject: [PATCH 1/2] build: syntax-check: exclude fewer tests * cfg.mk (local-checks-to-skip): Don't skip tests that pass. Remove names of renamed or removed tests. --- cfg.mk | 14 -------------- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/cfg.mk b/cfg.mk index 64bd26e..79dcb81 100644 --- a/cfg.mk +++ b/cfg.mk @@ -26,31 +26,17 @@ url_dir_list = \ # Tests not to run as part of "make distcheck". local-checks-to-skip = \ - changelog-check \ - check-AUTHORS \ - makefile-check \ - makefile_path_separator_check \ - patch-check \ sc_GPL_version \ - sc_always_defined_macros \ - sc_cast_of_alloca_return_value \ - sc_dd_max_sym_length \ sc_error_exit_success \ sc_file_system \ sc_immutable_NEWS \ sc_makefile_path_separator_check \ - sc_obsolete_symbols \ - sc_prohibit_S_IS_definition \ sc_prohibit_atoi_atof \ - sc_prohibit_jm_in_m4 \ sc_prohibit_quote_without_use \ sc_prohibit_quotearg_without_use \ sc_prohibit_stat_st_blocks \ - sc_root_tests \ sc_space_tab \ sc_sun_os_names \ - sc_system_h_headers \ - sc_tight_scope \ sc_two_space_separator_in_usage \ sc_error_message_uppercase \ sc_program_name \ -- 1.6.5.rc0.164.g5f6b0 >From 7bf84b60be8603f226af6244a3e63335586555d6 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[email protected]> Date: Tue, 8 Sep 2009 15:24:46 +0200 Subject: [PATCH 2/2] build: no longer skip the makefile PATH separator check * cfg.mk (local-checks-to-skip): Remove sc_makefile_path_separator_check. * python/tests/Makefile.am (tests): Use $(PATH_SEPARATOR), not ":" in shell search PATH definitions. --- cfg.mk | 1 - python/tests/Makefile.am | 23 +++++++++++++++-------- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/cfg.mk b/cfg.mk index 79dcb81..7e152f8 100644 --- a/cfg.mk +++ b/cfg.mk @@ -30,7 +30,6 @@ local-checks-to-skip = \ sc_error_exit_success \ sc_file_system \ sc_immutable_NEWS \ - sc_makefile_path_separator_check \ sc_prohibit_atoi_atof \ sc_prohibit_quote_without_use \ sc_prohibit_quotearg_without_use \ diff --git a/python/tests/Makefile.am b/python/tests/Makefile.am index 6011fef..11218a8 100644 --- a/python/tests/Makefile.am +++ b/python/tests/Makefile.am @@ -12,14 +12,21 @@ EXTRA_DIST = $(PYTESTS) if WITH_PYTHON tests: $(PYTESTS) @echo "## running Python regression tests" - -@(PYTHONPATH="..:../.libs:../src/.libs:$(srcdir)/../src:$$PYTHONPATH";\ - export PYTHONPATH; \ - LD_LIBRARY_PATH="$(top_builddir)/src/.libs:$$LD_LIBRARY_PATH" ; \ - export LD_LIBRARY_PATH; \ - for test in $(PYTESTS) ; \ - do log=`$(PYTHON) $(srcdir)/$$test` ; \ - if [ "`echo $$log | grep OK`" = "" ] ; then \ - echo "-- $$test" ; echo "$$log" ; fi ; done) + -@(p=..; \ + -@(p="$$p$(PATH_SEPARATOR)../.libs"; \ + p="$$p$(PATH_SEPARATOR)../src/.libs"; \ + p="$$p$(PATH_SEPARATOR)$(srcdir)/../src"; \ + p="$$p$(PATH_SEPARATOR)$$PYTHONPATH"; \ + PYTHONPATH=$$p; export PYTHONPATH; \ + p="$(top_builddir)/src/.libs"; \ + p="$$p$(PATH_SEPARATOR)$$LD_LIBRARY_PATH"; \ + LD_LIBRARY_PATH=$$p; export LD_LIBRARY_PATH; \ + for test in $(PYTESTS); do \ + log=`$(PYTHON) $(srcdir)/$$test`; \ + if [ "`echo $$log | grep OK`" = "" ]; then \ + echo "-- $$test"; echo "$$log"; \ + fi; \ + done) else tests: endif -- 1.6.5.rc0.164.g5f6b0 -- Libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
