On Mon, 2018-04-23 at 15:04 +0200, Ján Tomko wrote: > On Mon, Apr 23, 2018 at 02:44:57PM +0200, Martin Kletzander wrote: > > Let's make a rule out of it and document it. This is based on few sources: > > > > 1) Most of the code [1] used spaces after casts, so the patch to change it > > this > > way rather than the other way around is smaller > > Just because it's popular does not mean it's right.
I don't think there's a right or wrong in this case: it's a pure matter of preference, which makes the popularity relevant as it's as good an indicator as any as to how many people will be annoyed by the change ;) > ACK if you forbid spaces after casts instead. I'd rather have all spaces removed, even though that wouldn't be my personal preference, than keep mixing up the two approaches. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
