On 04/17/2018 05:43 PM, Ján Tomko wrote: > We have two leftover "capabilites" for qemu-img: > QEMU_IMG_BACKING_FORMAT_OPTIONS > QEMU_IMG_BACKING_FORMAT_OPTIONS_COMPAT > > The former says we are able to specify the backing format via -o > (which has been the case for a long time now) and the second one > says we can use -o compat to specify the qcow2 version. > > Since we require QEMU 1.5.0, we can always assume -o compat, > which was introduced in QEMU 1.1. > > Drop the test cases using FMT_OPTIONS which have a FMT_COMPAT > counterpart to prepare for deprecating FMT_OPTIONS (and these flags) > completely. > > Signed-off-by: Ján Tomko <[email protected]> > --- > .../qcow2-convert-nobacking.argv | 2 -- > .../storagevolxml2argvdata/qcow2-from-logical.argv | 2 -- > .../qcow2-nobacking-convert-prealloc.argv | 2 -- > .../qcow2-nobacking-prealloc.argv | 2 -- > tests/storagevolxml2argvdata/qcow2.argv | 2 -- > tests/storagevolxml2argvtest.c | 37 > ---------------------- > 6 files changed, 47 deletions(-) > delete mode 100644 tests/storagevolxml2argvdata/qcow2-convert-nobacking.argv > delete mode 100644 tests/storagevolxml2argvdata/qcow2-from-logical.argv > delete mode 100644 > tests/storagevolxml2argvdata/qcow2-nobacking-convert-prealloc.argv > delete mode 100644 tests/storagevolxml2argvdata/qcow2-nobacking-prealloc.argv > delete mode 100644 tests/storagevolxml2argvdata/qcow2.argv >
For some reason in my mind I had R-by'd the first two, but I guess I didn't - my bad... Reviewed-by: John Ferlan <[email protected]> John -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
