On Thu, May 17, 2018 at 12:15:08PM -0400, John Ferlan wrote:
> 
> 
> On 05/16/2018 06:11 PM, Filip Alac wrote:
> > Add support for hda 'output' codec for ich6 and ich9 sound devices,
> > which allow us to disable line-in for guest.
> > 
> > Fixes:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1126641
> > 
> > Signed-off-by: Filip Alac <filipa...@gmail.com>
> > ---
> >  docs/formatdomain.html.in                               | 5 +++--
> >  docs/schemas/domaincommon.rng                           | 1 +
> >  src/conf/domain_conf.c                                  | 3 ++-
> >  src/conf/domain_conf.h                                  | 1 +
> >  src/qemu/qemu_capabilities.c                            | 2 ++
> >  src/qemu/qemu_capabilities.h                            | 1 +
> >  src/qemu/qemu_command.c                                 | 5 ++++-
> >  tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml        | 1 +
> >  tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml        | 1 +
> >  tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml        | 1 +
> >  tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml        | 1 +
> >  tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml      | 1 +
> >  tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml        | 1 +
> >  tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml       | 1 +
> >  tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml      | 1 +
> >  tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml        | 1 +
> >  tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml       | 1 +
> >  tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml        | 1 +
> >  tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml        | 1 +
> >  tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml       | 1 +
> >  tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml         | 1 +
> >  tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml        | 1 +
> >  tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml        | 1 +
> >  tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml        | 1 +
> >  tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml         | 1 +
> >  tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml        | 1 +
> >  tests/qemustatusxml2xmldata/migration-in-params-in.xml  | 1 +
> >  tests/qemustatusxml2xmldata/migration-out-nbd-in.xml    | 1 +
> >  tests/qemustatusxml2xmldata/migration-out-nbd-out.xml   | 1 +
> >  tests/qemustatusxml2xmldata/migration-out-params-in.xml | 1 +
> >  tests/qemustatusxml2xmldata/modern-in.xml               | 1 +
> >  tests/qemuxml2argvdata/sound-device.args                | 2 ++
> >  tests/qemuxml2argvdata/sound-device.xml                 | 2 ++
> >  tests/qemuxml2argvtest.c                                | 1 +
> >  tests/qemuxml2xmloutdata/sound-device.xml               | 2 ++
> >  35 files changed, 45 insertions(+), 4 deletions(-)
> > 
> 
> A slightly different take than Erik - I had started this earlier, got
> distracted, and didn't come back to it until I saw Erik's reply.
> 
> Way too much in one patch - please split this up into multiple patches:
> 
> 1. docs, conf, xml2xmltest
> 2. qemu_capabilities
> 3. qemu, xml2argvtest
> 
> and then add a 4th patch:
> 
> 4. docs/news.xml  to describe the feature/addition
> 
> However, I see that "output" is in the qemu 1.5.3 caps, so since 1.5 is
> our lowest supported qemu emulator, do we even need a capability? IOW:
> When was "output" added as an option?  I see that hda-duplex and
> hda-micro seem to fall into the same category - in the 1.5.3 output, but
> we cannot just remove those - they have to be specially handled.

'duplex' and 'output' were introduced in 0.14.0 but 'micro' was
introduced in 1.1.0.  Since the HDA codec doesn't have to be compiled
in we should have at least one capability to make sure that it's
available.  I guess that it will not hurt to have separate capability
for each codec.

Pavel

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to