On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
> ---
>  src/access/viraccessdriver.h       |  5 ++++
>  src/access/viraccessdrivernop.c    | 10 ++++++++
>  src/access/viraccessdriverpolkit.c | 21 ++++++++++++++++
>  src/access/viraccessdriverstack.c  | 24 ++++++++++++++++++
>  src/access/viraccessmanager.c      | 15 ++++++++++++
>  src/access/viraccessmanager.h      |  5 ++++
>  src/access/viraccessperm.c         |  7 +++++-
>  src/access/viraccessperm.h         | 39 ++++++++++++++++++++++++++++++
>  src/rpc/gendispatch.pl             |  3 ++-
>  9 files changed, 127 insertions(+), 2 deletions(-)
> 

Ahhh... so that's where this magic is ;-)

Minor nit below...

Reviewed-by: John Ferlan <jfer...@redhat.com>

John

[...]

> diff --git a/src/access/viraccessperm.h b/src/access/viraccessperm.h
> index 1817da73bc..0ea1f7a489 100644
> --- a/src/access/viraccessperm.h
> +++ b/src/access/viraccessperm.h
> @@ -94,6 +94,13 @@ typedef enum {
>       */
>      VIR_ACCESS_PERM_CONNECT_SEARCH_NWFILTERS,
>  
> +    /**
> +     * @desc: List network filter bindings
> +     * @message: Listing network filter bindings requires authorization
> +     * @anonymous: 1
> +     */
> +    VIR_ACCESS_PERM_CONNECT_SEARCH_NWFILTER_BINDINGS,
> +
>  

Should we keep the double empty line just for this? IDC, just different
than the other spacing.

>      /**
>       * @desc: Detect storage pools
> @@ -486,6 +493,37 @@ typedef enum {
>      VIR_ACCESS_PERM_NWFILTER_LAST
>  } virAccessPermNWFilter;
>  

[...]

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to