On 05/23/2018 08:32 AM, Lin Ma wrote: > v2 -> v3: > Most of patches in original v2 patchset were pushed, only 2 patches left, > So create a new patchset for including the 2 patches and 6 new completion > patches which about secret-event, pool-event and nodedev-event. > > (Borrowed code & idea from Michal Privoznik for these patches design) > > > Lin Ma (8): > virsh-secret: Rename vshEventCallback to vshSecretEventCallback > virsh: Add event name completion to 'secret-event' command > virsh: Move vshEventCallback structure definition to virsh-domain.h > virsh: Add event name completion to 'event' command > virsh-pool: Rename vshEventCallback to vshPoolEventCallback > virsh: Add event name completion to 'pool-event' command > virsh-nodedev: Rename vshEventCallback to vshNodedevEventCallback > virsh: Add event name completion to 'nodedev-event' command > > tools/virsh-completer.c | 119 > ++++++++++++++++++++++++++++++++++++++++++++++++ > tools/virsh-completer.h | 15 ++++++ > tools/virsh-domain.c | 9 +--- > tools/virsh-domain.h | 8 ++++ > tools/virsh-nodedev.c | 19 +++----- > tools/virsh-nodedev.h | 8 ++++ > tools/virsh-pool.c | 19 +++----- > tools/virsh-pool.h | 8 ++++ > tools/virsh-secret.c | 18 +++----- > tools/virsh-secret.h | 8 ++++ > 10 files changed, 189 insertions(+), 42 deletions(-) >
I've fixed all the issues I've found, ACKed and pushed. Would be nice if you can provide news.xml patch that mention these additions. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
