On Tue, May 29, 2018 at 09:48:51 +0200, Ján Tomko wrote: > On Tue, May 29, 2018 at 09:30:05AM +0200, Peter Krempa wrote: > > On Mon, May 28, 2018 at 15:54:02 +0200, Ján Tomko wrote: > > > Further patches will introduce validation and a default setting > > > of def->os.bootDevs in postParse. > > > > > > Introduce a feature flag to opt out of this and set it in the vmx > > > driver. > > > > This does not clarify in any way why it is required. > > > > > Introduce a feature flag to opt out of this and set it in the vmx > driver, otherwise we would be adding it <boot dev='hd'/> into every > vmx config despite having no way to change it.
ACK to the patch if you add this wording. > > (Alternatively, if booting from hard-drive is the default, we can just > leave it in because none of the vmx code even touches bootDevs, so > it will be safely ignored) It very well might be the default. The capability can easily be deleted later. > > Jano > > > > > > > Signed-off-by: Ján Tomko <[email protected]> > > > --- > > > src/conf/domain_conf.h | 1 + > > > src/vmx/vmx.c | 3 ++- > > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > -- > libvir-list mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/libvir-list
signature.asc
Description: PGP signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
