On Tue, 10 Jul 2018 at 16:30, Erik Skultety <eskul...@redhat.com> wrote: > > On Sat, Jun 30, 2018 at 02:30:09PM +0530, Sukrit Bhatnagar wrote: > > Add rule to ensure that there is no semicolon at the end of > > the line where a VIR_DEFINE_* cleanup macro is invoked. > > > > Signed-off-by: Sukrit Bhatnagar <skrtbht...@gmail.com> > > --- > > NACK, the compiler will fail in such case, so the syntax-rule doesn't bring > any > benefit to us.
The make check does not raise an error when a semicolon is appended. I guess compiler just ignores extra semicolons. I added this rule because if a semicolon is not needed after a VIR_DEFINE, it should not be there. But I can remove it if it is not that useful. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
