Re: [libvirt] [PATCH v3 06/28] virLockManagerSanlockAddResource: Do not ignore unknown resource types

Thu, 30 Aug 2018 10:01:17 -0700 


On 08/27/2018 04:08 AM, Michal Privoznik wrote:
> Currently, there are only two types of resource. So effectively
> this is a dead code. However, that assumption can change and we
> shouldn't just silently ignore the error.
> 
> Signed-off-by: Michal Privoznik <[email protected]>
> ---
>  src/locking/lock_driver_sanlock.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

True and this then follows what lockd does in
virLockManagerLockDaemonAddResource

Reviewed-by: John Ferlan <[email protected]>

John

--
libvir-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libvir-list























					Reply via email to