On Wed, Sep 12, 2018 at 10:57:32AM +0200, Fabiano Fidêncio wrote: > virLXCCgroupSetupBlkioTune() and qemuSetupBlkioCgroup() and > virLXCCgroupSetupCpuTune() and qemuSetupCpuCgroup() are the most similar > functions between QEMU and LXC code. > > Let's move their common code to virCgroup. > > Mind that the first two patches are basically preparing the ground for > the changes introduced in the last two patches.
Hi, definitely good idea to remove code duplication! We have similar issue with the virDomainSetBlkioParameters for QEMU and LXC drivers. The code to set cgroup values is the same. Since the common object is domain how about introducing virDomainSetupBlkioTune and virDomainSetupMemTune and move it into domain_conf.c, that way we don't have to extract domain specific data into src/util. Another benefit is that it will not cause me merge conflicts because I'm rewriting cgroup code and adding support for cgroup v2. Pavel
signature.asc
Description: PGP signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
