Re: [libvirt] [PATCH v4 18/23] security_dac: Fix info messages when chown()-ing

Mon, 17 Sep 2018 14:53:59 -0700 


On 09/10/2018 05:36 AM, Michal Privoznik wrote:
> Firstly, the message that says we're setting uid:gid shouldn't be
> called from virSecurityDACSetOwnershipInternal() because
> virSecurityDACRestoreFileLabelInternal() is calling it too.
> Secondly, there are places between us reporting label restore and
> us actually doing it where we can quit. Don't say we're doing
> something until we are actually about to do it.
> 
> Signed-off-by: Michal Privoznik <[email protected]>
> ---
>  src/security/security_dac.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 

Of course both of this adjustments bring to the forefront the odditity
of using virSecurityDACTransactionAppend when/if @path == NULL - I mean,
what's the purpose then?  *Especially* if there's more than one!

Dang - so does this mean the previous patch needs adjustment?

For this though,

Reviewed-by: John Ferlan <[email protected]>

John

--
libvir-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libvir-list























					Reply via email to