On 09/17/2018 08:40 PM, John Ferlan wrote: > > > On 09/10/2018 05:36 AM, Michal Privoznik wrote: >> At the beginning of each dispatch function we check if owner >> attributes were registered (these consist of ID, UUID, PID and >> name). The check then consists of checking if ID is not zero. >> This is not going to work with >> VIR_LOCK_MANAGER_OBJECT_TYPE_DAEMON which doesn't set ID. Switch >> to setting PID which is available for both cases. > > It would if daemon used @pid for ID ;-) > >> >> Signed-off-by: Michal Privoznik <[email protected]> >> --- >> src/locking/lock_daemon_dispatch.c | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> > > Looking through a bit of history and came across an oh shinola moment, see: > > commit id ee3eddb332 > > You may need to implement what I suggest above and move on from there.
Ah, this is a very good point. I'll have VIR_LOCK_MANAGER_OBJECT_TYPE_DAEMON set id to PID. This one should be dropped then. Michal -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
