Re: [libvirt] [PATCH 1/5] qemu: Properly report VIR_DOMAIN_EVENT_RESUMED_FROM_SNAPSHOT

Wed, 19 Sep 2018 07:49:30 -0700 


On 09/12/2018 08:55 AM, Jiri Denemark wrote:
> VIR_DOMAIN_EVENT_RESUMED_FROM_SNAPSHOT was defined but not used anywhere
> in our event generation code. This fixes qemuDomainRevertToSnapshot to
> properly report why the domain was resumed.
> 
> Signed-off-by: Jiri Denemark <[email protected]>
> ---
>  src/qemu/qemu_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: John Ferlan <[email protected]>

John

So the event detail was introduced by commit c1ff5dc63d, but never added
to anything.  Even when commit 88fe7a4b originally implemented the
"was_stopped" as STARTED_FROM_SNAPSHOT. When I changed the logic in
commit 5efcfb96 it doesn't seem I was considering the "detail", but
rather just the event.

--
libvir-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libvir-list






















					Reply via email to