On Fri, Feb 22, 2019 at 12:08 PM Michal Privoznik <[email protected]> wrote:
> On 2/21/19 7:44 PM, David Kiarie wrote: > > Signed-off-by: David Kiarie <[email protected]> > > --- > > src/xenconfig/xen_xl.c | 1 + > > src/xenconfig/xen_xl.h | 1 + > > tests/xlconfigtest.c | 1 + > > 3 files changed, 3 insertions(+) > > > > diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c > > index accfc3a..8029579 100644 > > --- a/src/xenconfig/xen_xl.c > > +++ b/src/xenconfig/xen_xl.c > > @@ -2,6 +2,7 @@ > > * xen_xl.c: Xen XL parsing functions > > * > > * Copyright (c) 2015 SUSE LINUX Products GmbH, Nuernberg, Germany. > > + * Copyright (C) 2014 Kahurani Kiarie > > * > > * This library is free software; you can redistribute it and/or > > * modify it under the terms of the GNU Lesser General Public > > diff --git a/src/xenconfig/xen_xl.h b/src/xenconfig/xen_xl.h > > index e519186..20b9f3d 100644 > > --- a/src/xenconfig/xen_xl.h > > +++ b/src/xenconfig/xen_xl.h > > @@ -2,6 +2,7 @@ > > * xen_xl.h: Xen XL parsing functions > > * > > * Copyright (c) 2015 SUSE LINUX Products GmbH, Nuernberg, Germany. > > + * Copyright (c) 2014 Kahurani Kiarie > > * > > * This library is free software; you can redistribute it and/or > > * modify it under the terms of the GNU Lesser General Public > > diff --git a/tests/xlconfigtest.c b/tests/xlconfigtest.c > > index b1eb8a0..158d793 100644 > > --- a/tests/xlconfigtest.c > > +++ b/tests/xlconfigtest.c > > @@ -3,6 +3,7 @@ > > * > > * Copyright (C) 2007, 2010-2011, 2014 Red Hat, Inc. > > * Copyright (c) 2015 SUSE LINUX Products GmbH, Nuernberg, Germany. > > + * Copyright (C) Kahurani Kiarie > > * > > * This library is free software; you can redistribute it and/or > > * modify it under the terms of the GNU Lesser General Public > > > > Frankly, I find theese lines useless. Git blame tells you who wrote > which lines of code. I'm no laywer, but the way I understand copyrights > in GPL projects is that it comes important only if project wants to > change the licence (e.g. to BSD). Then it has to have confirmation from > all copyright holders. > > But problem with keeping copyright holders in files is that noone tracks > if they are still true. I mean, imagine somebody from company XYZ adding > a few lines to virsomething.c. They also add a copyright line into the > file. Later, when the code is reworked those lines are removed, but > noone will ever remove the copyright line and thus it's outdated. > > Therefore, I think we should remove all copyright lines from all the > files and just trust git to be able to generate list of authors from > given state of repo. > exactly, that would fair. > > Michal >
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
