On 7/8/19 10:37 PM, Eric Blake wrote: > Even though we don't accept any flags, it is unfriendly to callers > that use the modern API to have to fall back to the flag-free API. > > Note that virDomainBlockStats does not trivially forward to > virDomainBlockStatsFlags, so that one is omitted. > > Signed-off-by: Eric Blake <[email protected]> > --- > src/test/test_driver.c | 34 ++++++++++++++++++++++++++++------ > 1 file changed, 28 insertions(+), 6 deletions(-) > > diff --git a/src/test/test_driver.c b/src/test/test_driver.c > index 7dd448bb20..49d7030d21 100644 > --- a/src/test/test_driver.c > +++ b/src/test/test_driver.c > @@ -2469,12 +2469,15 @@ static int testDomainSetMaxMemory(virDomainPtr domain, > return 0; > } > > -static int testDomainSetMemory(virDomainPtr domain, > - unsigned long memory) > +static int testDomainSetMemoryFlags(virDomainPtr domain, > + unsigned long memory, > + unsigned int flags) > { > virDomainObjPtr privdom; > int ret = -1; > > + virCheckFlags(0, -1); > +
As discussed in v2, this should probably accept VIR_DOMAIN_AFFECT_LIVE,
and maybe even VIR_DOMAIN_AFFECT_MAXIMUM_MEMORY...
> +static int testDomainSetMemory(virDomainPtr domain,
> + unsigned long memory)
> +{
> + return testDomainSetMemoryFlags(domain, memory, 0);
where this should pass VIR_DOMAIN_AFFECT_LIVE instead of 0, and we may
want to implement testDomainSetMaxMemory(),...
> +static int testDomainPinVcpu(virDomainPtr domain,
> + unsigned int vcpu,
> + unsigned char *cpumap,
> + int maplen)
> +{
> + return testDomainPinVcpuFlags(domain, vcpu, cpumap, maplen, 0);
and another interface that should probably pass VIR_DOMAIN_AFFECT_LIVE.
Looks like I'll be doing a v3.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
