On Fri, 2019-07-26 at 16:22 +0100, Daniel P. Berrangé wrote: > On Fri, Jul 26, 2019 at 03:59:23PM +0200, Andrea Bolognani wrote: > > On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote: > > > +remote/libvirtd.conf: remote/libvirtd.conf.in > > > + $(AM_V_GEN)sed \ > > > + -e '/:: CUT ENABLE_IP ::/d' \ > > > + -e '/:: END ::/d' \ > > > + -e 's/:: DAEMON_NAME ::/libvirtd/' \ > > > + < $^ > $@ > > > > Using $^ seems a bit weird considering that you have a single > > input... Any reason not to use $< here? > > it is an accident. > > > I would also use @DAEMON_NAME@ instead of ":: DAEMON_NAME ::" since > > the former style is already used everywhere for simple value > > replacement in .in files. > > The augeas files already use "::" which is why I picked that. So we'll > need another patch first to remove existing usage.
Yeah, it'd make sense to use @CONFIG@ as well. With $^ replaced with $< and ":: DAEMON_NAME ::" replaced with @DAEMON_NAME@, Reviewed-by: Andrea Bolognani <[email protected]> -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
