On Fri, Aug 2, 2019 at 1:23 PM Erik Skultety <[email protected]> wrote: > > On Tue, Jul 09, 2019 at 09:23:21PM +0200, Ilias Stamatis wrote: > > --- > > Explaining that the private data will come handy to hold the information > whether filesystems have been frozen would be nice.
Sure, just maybe let's not make it FS-specific only since we'll use that for other APIs too and there's nothing related to the FS APIs in this patch anyways. How about we add in the commit message something like: """ vm-specific data can be used by APIs that need to preserve some state between calls Some of them are: - FS-related APIs for remembering which mountpoints are frozen - virDomainSetTime / virDomainGetTime for maintaining time information - virDomainSetIOThreadParams for storing the I/O thread parameters - virDomainManagedSaveDefineXML for internally storing the VM definition """ > > Reviewed-by: Erik Skultety <[email protected]> -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
