On Thu, Oct 03, 2019 at 04:00:25PM +0200, Jiri Denemark wrote:
It is a container for a CPU models list (qemuMonitorCPUDefInfo) and a
number of elements in this list.


Surely introducing a new type with VIR_AUTOFREE_FUNC defined and not
using it would look strange.

But all the goto cleanup -> return -1 changes could be separated.

Signed-off-by: Jiri Denemark <jdene...@redhat.com>
---
src/qemu/qemu_capabilities.c | 24 ++++++----------
src/qemu/qemu_monitor.c      | 39 +++++++++++++++++++------
src/qemu/qemu_monitor.h      | 14 +++++++--
src/qemu/qemu_monitor_json.c | 56 ++++++++++++++----------------------
src/qemu/qemu_monitor_json.h |  2 +-
tests/qemumonitorjsontest.c  | 38 +++++++++---------------
6 files changed, 89 insertions(+), 84 deletions(-)


Reviewed-by: Ján Tomko <jto...@redhat.com>

Jano

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to