On Tue, 2019-08-27 at 21:46 -0400, Laine Stump wrote: > with info about support for using precreated tap/macvtap devices in > unprivileged libvirtd. > > Signed-off-by: Laine Stump <[email protected]> > --- > docs/news.xml | 13 +++++++++++++ > 1 file changed, 13 insertions(+)
You mentioned this was never reviewed, so here we go :) > + <change> > + <summary> > + qemu: Support use of precreated tap/macvtap devices by > unprivileged libvirtd > + </summary> > + <description> > + It is now possible for an unprivileged libvirtd to make use > + of tap and macvtap devices that were previously created by > + some other entity. Since is done by setting s/Since/This/ > + <code>managed='no'</code> along with the device name in the > + <code>target</code> subelement of <code><interface > + type='ethernet'></code> The description should end with a period. With the above fixed, and the patch updated so that it actually applies, Reviewed-by: Andrea Bolognani <[email protected]> -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
